Messages in this thread Patch in this message | | | Date | Sun, 19 Oct 2003 22:17:42 -0700 (PDT) | From | "Noah J. Misch" <> | Subject | [PATCH] Missing include in swap.h for some architectures |
| |
Greetings All,
This flaw broke kernel builds configured with SWAP=n on some architectures, particularly alpha and ia64. Since i386 managed to include pagemap.h indirectly, this did not crop up there. See log for details.
This applies to linux-2.5 BK as of 0400 UTC 10/20/2003 and passes all kinds of ridiculous compile tests, probably including (allyesconfig - broken stuff) on sparc, sparc64, ia64, alpha, and i386. Don't know about VAX...
One could place this include within the #ifdef'ed block that contains the relevant function uses, but that's not generally within the style of this file or most others, per my recollection.
I didn't know who takes things like this, so if anyone would like to pick this up, please do so. Otherwise, I will send it to Linus after a few days.
# This is a BitKeeper generated patch for the following project: # Project Name: Linux kernel tree # This patch format is intended for GNU patch command version 2.5 or higher. # This patch includes the following deltas: # ChangeSet 1.1367 -> 1.1368 # include/linux/swap.h 1.79 -> 1.80 # # The following is the BitKeeper ChangeSet Log # -------------------------------------------- # 03/10/16 noah@caltech.edu 1.1368 # The linux/swap.h header uses the page_cache_release and release_pages # functions declared in linux/pagemap.h when CONFIG_SWAP is disabled. Add # an include of linux/pagemap.h so swap.h finds those declarations on # architectures that don't include pagemap.h indirectly. # -------------------------------------------- # diff -Nru a/include/linux/swap.h b/include/linux/swap.h --- a/include/linux/swap.h Fri Oct 17 13:40:06 2003 +++ b/include/linux/swap.h Fri Oct 17 13:40:06 2003 @@ -4,6 +4,7 @@ #include <linux/config.h> #include <linux/spinlock.h> #include <linux/linkage.h> +#include <linux/pagemap.h> #include <linux/mmzone.h> #include <linux/list.h> #include <linux/sched.h> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |