lkml.org 
[lkml]   [2003]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] kfree_skb() bug in 2.4.22
Date
On Wednesday 08 October 2003 15:47, David S. Miller wrote:
> On Wed, 08 Oct 2003 09:09:48 -0400
>
> Jeff Garzik <jgarzik@pobox.com> wrote:
> > I would prefer that you fix your code instead, to not pass NULL to
> > kfree_skb()...
>
> Absolutely, there is no valid reason to pass NULL into these
> routines.

Would you mind __attribute_nonnull__ for these functions, if we
enable GCC 3.3 support for this[1]?


[1] Which includes editing the compiler.h and gcc3-compiler.h and so on.

Regards

Ingo Oeser


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:49    [W:0.064 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site