[lkml]   [2003]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] kfree_skb() bug in 2.4.22
    Ingo Oeser wrote:
    > On Friday 10 October 2003 15:00, David S. Miller wrote:
    >>Ingo Oeser <> wrote:
    >>>Would you mind __attribute_nonnull__ for these functions, if we
    >>>enable GCC 3.3 support for this[1]?
    >>I would say yes, but why? All this attribute does is optimize
    >>away tests for NULL which surprise surprise we don't have any
    >>of in kfree_skb().
    > And it wouldn't warn about passing NULL to these functions? That's bad...
    > But maybe sparse/smatch are better for this...

    Things like smatch, sparse, and checker can use the __attribute_nonnull__.
    I'd say it's a good idea. Should I submit the patch, then, since I'm
    the one who like the idea?
    - Dan

    Dan Kegel

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:49    [W:0.025 / U:4.804 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site