Messages in this thread | | | Date | Wed, 1 Oct 2003 17:41:43 +0300 | From | Muli Ben-Yehuda <> | Subject | Re: [PATCH] CONFIG_* In Comments Considered Harmful |
| |
On Wed, Oct 01, 2003 at 03:19:52PM +0100, Dave Jones wrote:
> Maybe it should be taught to parse comments? There are zillions of > #endif /* CONFIG_FOO */ > braces in the tree. Why is this one special ?
I wondered the same, until I noticed:
#if defined(WANT_PAGE_VIRTUAL) ^^^^^^^^^^^^^^^^^ void *virtual; /* Kernel virtual address (NULL if not kmapped, ie. highmem) */ #endif /* CONFIG_HIGMEM || WANT_PAGE_VIRTUAL */ ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^
the #defined check is on WANT_PAGE_VIRTUAL only - the script tripped over CONFIG_HIGMEM, which is in the #endif only. -- Muli Ben-Yehuda http://www.mulix.org
[unhandled content-type:application/pgp-signature] | |