Messages in this thread | | | Date | Wed, 1 Oct 2003 23:15:53 +0300 | From | Muli Ben-Yehuda <> | Subject | Re: [PATCH] CONFIG_* In Comments Considered Harmful |
| |
On Wed, Oct 01, 2003 at 05:10:11PM +0200, J?rn Engel wrote:
> > > --- a/include/linux/mm.h 28 Sep 2003 04:06:20 -0000 1.5 > > > +++ b/include/linux/mm.h 1 Oct 2003 13:15:53 -0000 > > > @@ -196,7 +196,7 @@ struct page { > > > #if defined(WANT_PAGE_VIRTUAL) > > > void *virtual; /* Kernel virtual address (NULL if > > > not kmapped, ie. highmem) */ > > > -#endif /* CONFIG_HIGMEM || WANT_PAGE_VIRTUAL */ > > > +#endif /* CONFIG_HIGHMEM || WANT_PAGE_VIRTUAL */ > > > }; > > > > This is broken, the CONFIG_HIG(H)MEM shouldn't be there at all. Look > > at the #if defined(...) line.
[snipped]
Looks like this patch made it past Linus's famous patch barriers and into the bk tree after all. J?rn, I trust you'll send a patch to revert it? (Linus, if you want to fix it by hand, just deleted the CONFIG_HIGHMEM bit completely from the #endif line). -- Muli Ben-Yehuda http://www.mulix.org
[unhandled content-type:application/pgp-signature] | |