[lkml]   [2002]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH]: 2.5.38uc1 (MMU-less support)
Hi Matthew,

Some more comments on the ethernet driver.

BTW, the original this came from is in the kernel tree
at arch/ppc/8xx_io/fec.c.

Matthew Wilcox wrote:
> Motorola 5272 ethernet driver:
> * In, let's conditionalise it on CONFIG_PPC or something
> * Can you use module_init() so it doesn't need an entry in Space.c?

I don't think this will work. This is not a device that can be
determined to be present like a PCI device. It is more like an
ISA device, it needs to be probed to figure out if it is really
there. I can't see any way not to use Space.c for non-auto-detectable
type devices... (Offcourse I could be missing something :-)

> * You're defining CONFIG_* variables in the .c file. I don't know whether
> this is something we're still trying to avoid doing ... Greg, you seem
> to be CodingStyle enforcer, what's the word?

I missed this the first time through :-)
I am not sure what you mean, CodingStyle enforcer?
Can you elaborate for me?


Greg Ungerer -- Chief Software Wizard EMAIL:
SnapGear Pty Ltd PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB:

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:29    [W:0.053 / U:10.332 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site