lkml.org 
[lkml]   [2002]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PCI Cleanup
Minor comments:

On Wed, Aug 21, 2002 at 05:59:31PM -0700, Hanna Linder wrote:
> +static int gapspci_write(struct pci_bus *bus, unsigned int devfn,
> + int where, u32 val)

You forgot the size parameter.

> {
> - if (BBA_SELECTED(dev))
> - outl(val, GAPSPCI_BBA_CONFIG+where);
> -
> - return PCIBIOS_SUCCESSFUL;
> + if (BBA_SELECTED(bus, devfn)) {
> + switch (size) {
> + case 1:
> + if (BBA_SELECTED(bus, devfn))
> + outb((u8)val, GAPSPCI_BBA_CONFIG+where);
> + break;
> + case 2:
> + if (BBA_SELECTED(bus, devfn))
> + outw((u16)val, GAPSPCI_BBA_CONFIG+where);
> + break;
> + case 4:
> + if (BBA_SELECTED(bus, devfn))
> + outl(val, GAPSPCI_BBA_CONFIG+where);
> + break;
> + }
> + }
> + return PCIBIOS_SUCCESSFUL;

Your formatting is a bit off here (the case statements should be one
level to the right.)

Other than that, looks good.

thanks,

greg k-h

> }
>
> static struct pci_ops pci_config_ops = {
> - gapspci_read_config_byte,
> - gapspci_read_config_word,
> - gapspci_read_config_dword,
> - gapspci_write_config_byte,
> - gapspci_write_config_word,
> - gapspci_write_config_dword
> + .read = gapspci_read,
> + .write = gapspci_write,
> };
>
>
> @@ -143,7 +125,7 @@
>
> for (ln=bus->devices.next; ln != &bus->devices; ln=ln->next) {
> dev = pci_dev_b(ln);
> - if (!BBA_SELECTED(dev)) continue;
> + if (!BBA_SELECTED(bus, dev->devfn)) continue;
>
> printk("PCI: MMIO fixup to %s\n", dev->name);
> dev->resource[1].start=0x01001700;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.051 / U:0.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site