Messages in this thread |  | | Date | Thu, 22 Aug 2002 08:42:13 -0700 | From | Greg KH <> | Subject | Re: PCI Cleanup |
| |
On Thu, Aug 22, 2002 at 12:11:41PM +0200, Gérard Roudier wrote: > > > On Wed, 21 Aug 2002, Hanna Linder wrote: > > > Here is the first part of the sh port of the pci_ops > > changes. If anyone can compile this for Sega let me > > know if there are any problems. > > The 'val' pointer is declared 'u32 *', then casted 'u8 *' or 'u16 *' if > needed. The compiler will not warn you. But user that wants to operate on > u8 or u16 has to cast the 'val' argument to 'u32 *' and should get a > warning from any decent C compiler. The normal C-way for such > 'sorry-typed' argument is 'void *val', IMO.
We are filling up a u32 here (see the previous patches), so leaving this as a u32 * and casting for the other sizes makes sense in this situation.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |