Messages in this thread | | | Subject | Re: [PATCH -ac] Panicking in morse code | From | Andi Kleen <> | Date | 19 Jul 2002 12:38:24 +0200 |
| |
Andrew Rodland <arodland@noln.com> writes:
> I was researching panic_blink() for someone who needed a little help, > when I noticed the comment above the function definition, not being the > kind to step down from a challenge (unless it's just really hard), I > decided to write morse code output code.
Great. Congratulations (having written the original comment).
I would encode the morse strings as bits in a integer instead of strings though (perhaps with some macros to make it readable), that should shrink it quite a bit.
> > The option panicblink= has been hijacked to be a simple bitfield: > bit 1 : blink LEDs > bit 2 : sound the PC speaker. > > the blinking option depends only on pc_keyb.c. the pcspeaker option > depends on kb_mksound() actually doing something. At the moment, both of > these mean i386. The call to panic_blink() in panic() is still guarded > by an i386 #ifdef, anyway, for the moment. The default is to blink only, > because I figured the beeps would be too annoying. Opinions?
I would consider beeps annoying, but then I usually just cut the beeper line on any new PC I install so personally I do not care. Still imagine what a machine room that overheated and caused several boxes to panic would sound like...
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |