Messages in this thread | | | Date | Wed, 17 Jul 2002 09:24:46 +0100 | From | Russell King <> | Subject | Re: [patch 1/13] minimal rmap |
| |
On Tue, Jul 16, 2002 at 10:29:14PM -0700, Andrew Morton wrote:
I'm puzzling over this difference:
> --- /dev/null Thu Aug 30 13:30:55 2001 > +++ 2.5.26-akpm/include/asm-arm/proc-armv/rmap.h Tue Jul 16 21:59:40 2002 >... > +static inline void pgtable_add_rmap(pte_t * ptep, struct mm_struct * mm, unsigned long address) > +{ > + struct page * page = virt_to_page(ptep); > + > + page->mm = mm; > + page->index = address & ~((PTRS_PER_PTE * PAGE_SIZE) - 1); > +}
and
> --- /dev/null Thu Aug 30 13:30:55 2001 > +++ 2.5.26-akpm/include/asm-generic/rmap.h Tue Jul 16 21:59:40 2002 > +static inline void pgtable_add_rmap(struct page * page, struct mm_struct * mm, unsigned long address) > +{ > +#ifdef BROKEN_PPC_PTE_ALLOC_ONE > + /* OK, so PPC calls pte_alloc() before mem_map[] is setup ... ;( */ > + extern int mem_init_done; > + > + if (!mem_init_done) > + return; > +#endif > + page->mapping = (void *)mm; > + page->index = address & ~((PTRS_PER_PTE * PAGE_SIZE) - 1); > +}
Note that the ARM one seems to be using page->mm but everything else uses page->mapping.
Also, this comment:
> + * ARM is different since hardware page tables are smaller than > + * the page size and Linux uses a "duplicate" one with extra info. > + * For rmap this means that the first 2 kB of a page are the hardware > + * page tables and the last 2 kB are the software page tables.
is no longer true for 2.5 (although it is still true for 2.4.)
-- Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux http://www.arm.linux.org.uk/personal/aboutme.html
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |