Messages in this thread | | | Date | Tue, 12 Mar 2002 00:13:18 -0700 | From | Erik Andersen <> | Subject | Re: [patch] My AMD IDE driver, v2.7 |
| |
On Mon Mar 11, 2002 at 05:58:41PM -0700, Erik wrote: > I have no argument with basic command validation. But take a > look at ide_cmd_type_parser(), for example. Do we really need a > giant switch statement listing all the allowed commands, just so > we can throw back a IDE_DRIVE_TASK_INVALID to user-space if they
In looking closer at the ide driver, it turns out that ide_cmd_type_parser() is _not_ filtering HDIO_DRIVE_TASKFILE ioctl commands at all. My mistake. There is actually no filtering at all HDIO_DRIVE_TASKFILE ioctl.
Strangely enough, ide_cmd_type_parser() is filtering commands issued by the ide driver itself.
-Erik
-- Erik B. Andersen http://codepoet-consulting.com/ --This message was written using 73% post-consumer electrons-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |