[lkml]   [2002]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [PATCH] block_dev.c: fsync() on close() considered harmful
Christoph Hellwig [] wrote:
> Hi Alan,
> I don't see any standard specifying that fsync should be done on
> every blockdevice close.
> Any chance you could add the below patch to the next -ac release?
> Christoph

I am writing a partitionable block device driver for the 2.4 kernel.
Once the driver is loaded and the device mounted, reading, writing,
and ioctls work properly.

The driver becomes unstable after many mounts/unmounts, and I have
come to suspect that I am not calling fsync_dev() correctly.

I do call fsync_dev() on release as well as on remove.
Is this incorrect? Can it lead to instability? I've counted four
different ways in which the driver dies, including a call to
BUG() in buffer.c...

Thank you,


Do You Yahoo!?
Yahoo! Sports - Coverage of the 2002 Olympic Games
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:20    [W:0.030 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site