lkml.org 
[lkml]   [2002]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: swsusp: don't eat ide disks
From
Date
On Sun, 2002-11-03 at 14:57, benh@kernel.crashing.org wrote:
> Hrm... I don't think so Alan. The PM ordering is bus driven,
> so actual bus binding of the disk is it's controller, not
> the request queue which is the functional binding. It's up to
> the disk driver to shut down processing of the request queue.

That requires code in every driver. Duplicated, hard to write, likely to
be racey code. Thats bad.

The bigger picture really should be

ACPI etc "I want to suspend to disk"

PM layer
Suspend the non I/O tasks (btw reminds me - eh tasks and
all workqueues may be I/O tasks at times)
Complete all the block I/O queues
Throw out the pages we can evict
Write suspend image

Jump to PM layer "power off" logic

If you do it that way up then no drivers need to be hacked about.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:30    [from the cache]
©2003-2011 Jasper Spaans