Messages in this thread | | | Date | Thu, 17 Oct 2002 20:35:52 -0700 | From | Andrew Morton <> | Subject | Re: 2.5.41 still not testable by end users |
| |
Andi Kleen wrote: > > Andrew Morton <akpm@digeo.com> writes: > > > > request_irq() needs to take the allocation mode as an argument. > > Should always have. Sigh. I'll fix it up sometime. > > If you change it I would change it to let the caller pass it in. Then > it's explicit and most drivers can just slab it somewhere in their > private structures without any allocation. >
Well that would require that the drivers become aware of struct irqaction, and make assumptions about how the particular arch handles interrupts.
But it's a bit academic. ia32's request_irq() calls proc_mkdir() and create_proc_entry(). So there's no point in feeding gfp_flags down into request_irq or whatever. We need to fix IDE still. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |