lkml.org 
[lkml]   [2002]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subjects390x build warnings from <linux/module.h>
Date
Hi,

during 'make modules' on s390x, I see lots of warnings about 'ignoring
changed section attributes for __ksymtab' that I have found to be the
result of changeset 1.373.196.1, where Kai changed the defaults for module
exports to 'no symbols exported'.

The problem is that there is a section '__ksymtab,"a"', while s390x
requires it to be '__ksymtab,"aw"' because modules must be compiled with
'-fpic' here, unlike afaics all the other architectures.

The patch below is a workaround for the Problem and should be
correct on all architectures, but I'd prefer if there was a nicer
way to do that.

Arnd <><

--- broken/include/linux/module.h 15 Oct 2002 07:55:01 -0000 1.8
+++ ugly/include/linux/module.h 15 Oct 2002 15:30:39 -0000
@@ -498,5 +498,9 @@
* "export all symbols" to modutils)
*/
+#ifndef __PIC__
__asm__(".section __ksymtab,\"a\"\n.previous");
+#else
+__asm__(".section __ksymtab,\"aw\"\n.previous");
+#endif
#endif

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 13:30    [W:0.046 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site