Messages in this thread |  | | Date | Mon, 3 Sep 2001 16:16:31 -0700 | From | David desJardins <> | Subject | Re: [IDEA+RFC] Possible solution for min()/max() war |
| |
Linus Torvalds <torvalds@transmeta.com> writes: > For example, let's look at this perfectly natural code: > > static int unix_mkname(struct sockaddr_un * sunaddr, int len, unsigned > *hashp) > { > if (len <= sizeof(short) || len > sizeof(*sunaddr)) > return -EINVAL; > ...
> code that is totally correct, and that it would make _no_ sense in > writing any other way.
The code is correct, but if one is adding explicit types, for clarity and to avoid introducing bugs, then I think that code like this is exactly where they most belong:
if ((size_t) len <= sizeof(short) || (size_t) len > sizeof(*sunaddr))
If that prevents one person from later writing buggy code like:
if ((size_t) len <= sizeof(short))
then it's a Good Thing.
-- David desJardins - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |