lkml.org 
[lkml]   [2001]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: NETDEV_CHANGE events when __LINK_STATE_NOCARRIER is modified
Date
Hello!

> Each bus should

Not all the device are bound to some "bus".



> Are you talking about his 140k patch?

Yes!

Size of patch and "simplicity" are orthogonal things.
It was simple like potatoe.


> I think a key point of my patch is that drivers now follow the method of
> other kernel drivers: perform all setup necessary, and then register the
> device in a single operation.

Nice. I agreed. I talk about other thing: after applying Andrew's patch
I saw good correct code. After you will fix all the devices, your patch will
be the same 140K or more due to killing refs t dev->name announced
to be illegal. 8)


> After register_foo(dev), all members of
> 'dev' are assumed to be filled in and ready for use. This is not the
> case ....................... using dev->init()...

Sorry? Why?


> Tangent - IMHO having register_netdev call dev->init is ugly and unusual
> compared to other driver APIs in the kernel. Your register function
> should not call out to driver functions, it should just register a new,
> already-set-up device in the subsystem and return.

Provided you teach me some way to generate unique identifiers, different
of device names.


> So you say a fatal bug remains in 2.4.5-pre1? If so please elaborate...


Probably, I am looking into different code, but I found only 15 references
to new interface.

Alexey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:53    [W:0.085 / U:12.132 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site