Messages in this thread | | | Date | Sun, 25 Feb 2001 15:19:30 +0100 | From | Rasmus Andersen <> | Subject | Re: [PATCH] s/isa//g in drivers/scsi/g_NCR5380.c and some cleanup (242) |
| |
On Sun, Feb 25, 2001 at 02:05:42PM +0000, Alan Cox wrote: [...] > > (An indication of how often this code path is used can be found in > > the fact that the previous define of NCR5380_write had its payload > > and address mixed up, probably making for wierd results should > > the code ever be executed.) > > The driver works for me nicely. Im not convinced by the changes of direction > either. At least not without a detailed audit on the 2.2 code. Some of the > naming is very misleading in that driver >
Looking at the define of NCR_5380_write
#define NCR5380_write(reg, value) isa_writeb(NCR5380_map_name + +NCR53C400_mem_base + (reg), value)
followed by an use of NCR5380_write
NCR5380_write(C400_CONTROL_STATUS_REG, CSR_BASE | CSR_TRANS_DIR);
I doubt that it is not the intention to write CSR_BASE | CSR_TRANS_DIR at the offset C400_CONTROL_STATUS_REG. But note that this argument swap only is in the code produced by -DCONFIG_SCSI_G_NCR5380_MEM. Perhaps you use CONFIG_SCSI_G_NCR5380_PORT? Otherwise I must admit that I have been had... -- Regards, Rasmus(rasmus@jaquet.dk)
Duct tape is like the force; it has a light side and a dark side, and it holds the universe together. -- Anonymous - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |