[lkml]   [2001]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectBlock driver design issue
I have a block driver I inherited that I working on that has a problem and
was wondering for cleaner solutions.

The driver can accept written characters from either userspace programs or from
the kernel. From userspace it uses sys_write. That in turn calls block_write.
There's almost 100 lines of duplicated code in a copy of the block_write
code in the driver "block_writek" as well as duplicate code in audit_write vs. audit_writek.
The only difference being down in block_write at the "copy_from_user(p,buf,chars); "
which becomes a "memcpy(p,buf,chars)" in the "block_writek" version.

I find this duplication of code to be inefficient. Is there a way to dummy up the
the 'buf' address so that the "copy_from_user" will copy the buffer from kernel space?
My assumption is that it wouldn't "just work" (which may also be an invalid assumption).

Suggestions? Abuse?


L A Walsh | Trust Technology, Core Linux, SGI | Voice: (650) 933-5338
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:13    [W:0.041 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site