Messages in this thread |  | | From | Andreas Dilger <> | Date | Fri, 12 Oct 2001 10:27:03 -0600 | Subject | Re: [PATCH] EFI GUID Partition Tables |
| |
On Oct 12, 2001 10:31 +0200, Martin Wilck wrote: > Richard, > > You've put the devfs_unregister_slave() inside an #ifdef. Yuk! It > > shouldn't be conditional. > > I did that because I didn't want to pollute your code. The function > was only needed for the UUID patch.
What would be more fitting is to put the actual declaration of devfs_unregister_slave() inside the #ifdef, and otherwise have an empty function which does nothing.
Cheers, Andreas -- Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto, \ would they cancel out, leaving him still hungry?" http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |