lkml.org 
[lkml]   [2000]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] for PAS16 functionality for 2.4
On Sun, 10 Sep 2000, Michael Elizabeth Chastain wrote:

> I have written documentation on Rules.make and the interface between
> Rules.make and Makefiles. It's here:
>
> ftp://ftp.shout.net/pub/users/mec/kbuild/x-Dkm-9.diff
>
> I would really like to see this documentation in the kernel. I've sent
> it to Linus three times, and he's ignored it three times. I will try
> some more after the release of 2.4.0.

Thanks for a very lucid docfile. I would really urge it be included. I
have just one metacomment. You have a number of sections (marked with
===) in the body of the text. Could we have those lines duplicated at
the top in an "intro" section? (Sort of like This file covers the
following topics...), perhaps with section designators. That would
allow the reader to quickly search to the specific part he/she was
interested in. I can produce a patch if you'd like.

> Anyways ... I'd appreciate it if a couple of people would try this patch
> so that I can submit it.
> diff -u -r -N linux-2.4.0-test8/Rules.make linux/Rules.make
> --- linux-2.4.0-test8/Rules.make Sun Aug 13 12:55:51 2000
> +++ linux/Rules.make Sun Sep 10 14:06:02 2000
> @@ -190,7 +190,7 @@
> #
> ifdef CONFIG_MODULES
>
> -SYMTAB_OBJS = $(LX_OBJS) $(OX_OBJS) $(MX_OBJS) $(MIX_OBJS)
> +SYMTAB_OBJS := $(sort $(LX_OBJS) $(OX_OBJS) $(MX_OBJS) $(MIX_OBJS))
>
> ifdef CONFIG_MODVERSIONS
> ifneq "$(strip $(SYMTAB_OBJS))" ""

I tried the patch and it works for me! Thanks again.

I'm also going to take a look at integrating sb functionality into
pas2_card.c as Mr. Hellwig suggested, unless someone thinks that is a
bad idea. That'll be later this week after I slog through integration
of partial fractions (yuk).


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.059 / U:8.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site