lkml.org 
[lkml]   [2000]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] for PAS16 functionality for 2.4
On Sun, 10 Sep 2000, Michael Elizabeth Chastain wrote:

> > Yepp. These warnings are there becuse of the way the list-style Makefiles
> > work. You will see lots of them in drivers/net and drivers/scsi, too.
>
> Here's a patch. Let me know if it works for you; if it does,
> I will submit it for 2.4.0.
>
> Here is some history: drivers/sound was the first of the list-style
> Makefiles and has been using lists since the late 2.1.NN series.
> Originally, drivers/sound/Makefile used $(sort ...) to remove duplicates.
>
> In 2.3.14, Linus introduced init sections. This made $(sort ...)
> unusable for the construction of O_OBJS and OX_OBJS.
>
> Today, O_OBJS and OX_OBJS may contain duplicates, and Rules.make is
> supposed to ignore the duplicates (while still preserving order).
> The fact that SYMTAB_OBJS causes these warning messages is a bug.
>
> Anyways ... I'd appreciate it if a couple of people would try this patch
> so that I can submit it.

I'll try your patch and look at your documentation. I agree that the
warnings are bugs. However, that was not the main point of my patch, it
was a side effect. The point is that there was code in pas2_card.c to
initialize the Soundblaster emulation in the PAS16. My patch merely
added the sb.o module to the list of those brought in when
CONFIG_SOUND_PAS was enabled in the configuration.

I suppose the more basic question is: Should the Soundblaster-specific
code in pas2_card.c be ripped out and leave only PAS-specific code in
the PAS driver? Some might argue that would be a "cleaner" way of doing
things. If the decision of my betters is that initialization should be
left in PAS and the driver as separate (the current situation) then I
believe my patch should stand.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.047 / U:3.552 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site