lkml.org 
[lkml]   [2000]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [bugfix] SMP, shm-2.3.52-A0
Date
From: "Ingo Molnar" <mingo@chiara.csoma.elte.hu>
>
> > + KASSERT(spin_is_locked(&kernel_flag));
>
> this is more readable i believe:
>
> if (!spin_is_locked(&kernel_flag))
> BUG();
>
> we have been adding such asserts since early 2.3. Btw., the dentry-assert
> should be done in namei.c and dentry.c, not open.c, this is how i caught
> the bug.

Will BUG() remain enabled in 2.4?
I always assumed that BUG() is the replacement for "*(int*)0=0", and that it
remains enabled in 2.4.

KASSERT() could be disabled in 2.4, and thus we could add such tests even to
time critical functions [I hope WAITQUEUE_DEBUG, SPINLOCK_DEBUG, the BUG()
in unlock_kernel() get disabled/removed before 2.4]


--
Manfred


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:57    [W:0.142 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site