lkml.org 
[lkml]   [2000]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [bugfix] SMP, shm-2.3.52-A0
Date
From: "Andrew Morton" <morton@nortelnetworks.com>
>
> Prevent this from ever happening again....
I would love to see a kassert() macro in the kernel, but

> +
> + KASSERT(spin_is_locked(&kernel_flag));
>
Did you actually test your patch?

from linux/include/linux/spinlock.h:
#ifndef __SMP__
#define spin_is_locked(lock) 0
#endif

you cannot use spin_is_locked() in your assert macro, you need a special
"kassert_locked()" macro :-(

--
Manfred



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:57    [W:0.070 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site