lkml.org 
[lkml]   [2000]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subjectre: [PATCH] linux-2.2.14/Documentation/sound/ALS007
Date
Hi all

> Attached please find a small documentation patch that helps generalize
> this file.

Basically I think these changes are fine. My only comment (which is
admittedly nit-picking) is that the "==="s under the title maybe should be
extended to match the new title's length. :)

> Why it is needed:
> The current driver/sound/sb_common.c also works for the ALS-100
> explicitly, (line 773) and just happens to work with the ALS-200.

The explicit detection of the ALS-100 was a pleasant side-effect of some
experiments I was doing with Mikael Pettersson back in April 1998 when the
first attempt at ALS007 detection code broke his ALS-100. As a result of a
number of (register-level) tests Mikael ran for me, I came up with the
current code which is able to distinguish between the ALS007 and ALS100.
The mention of the ALS100 at line 773 is only due to this.

> the Documentation/sound/ALS007 explains how to use the '007 code, but does
> not explain the '100 code.

A fair comment. The document appears as written only because I had no
personal experience with the ALS100 and didn't know for certain that the
steps I did with my ALS007 worked with the ALS100 (or ALS200 for that
matter) as well.

> These methods worked for my ALS200 chip, and it would be nice to tell
> people about it.

It's good to know that it works on the ALS200 as well and I agree that it
should be documented.

> Further, I suggest:
> mv Documentation/sound/ALS007 Documentation/sound/ALSxxx

Sounds consistant to me.

Regards
jonathan
--
* Jonathan Woithe jwoithe@physics.adelaide.edu.au *
* http://www.physics.adelaide.edu.au/~jwoithe/home.html *
***-----------------------------------------------------------------------***
** "Time is an illusion; lunchtime doubly so" **
* "...you wouldn't recognize a subtle plan if it painted itself purple *
* and danced naked on a harpsicord singing 'subtle plans are here again'" *

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:56    [W:0.033 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site