Messages in this thread |  | | Date | Thu, 7 Dec 2000 21:44:36 +1300 | From | Chris Wedgwood <> | Subject | Re: [RFC] Configuring synchronous interfaces in Linux |
| |
On Sat, Dec 02, 2000 at 02:48:10PM -0500, Donald Becker wrote:
It's certainly possible to break the driver up, but it will be even more of a problem to maintain. Some of the complicated media selection code applies to several generations. Splitting the driver to have a copy for each generation means a lot of duplicated code, which quickly leads to version skew.
So how does someone, like me for example, try to cleanly add support for something like ethtool when the only hardware they have is say 3c920 and they could care less about the rest?
The best thing I can see to do is to restructure the driver as is and try to get common paths for things like media setting and remove the module parameter hacks we now have; that way it should be possible to add ethtool support that works for everything...
... how does that sound?
--cw
P.S. Also, since only _two_ drivers actually support ethtool (hme and acenic) is everyone 100% happy they want this API? Surely now is the best time to invite discussion and promote ideas if people have requirements that ethtool can't satisfy? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |