[lkml]   [2000]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: Patch to remove undefined C code
>-----Original Message-----
>From: Alexander Viro []
>No arguments here, but proposed fixes were remarkably ugly. Example:
>tmp = *p++;
>*q = f(tmp, *p++);
>return p;
>is equivalent to more idiomatic
>*q = f(p[0], p[1]);
>return p+2;
>And example with copying the string up to the comma... Yuck. Legal C !=
>decent C.

Strongly agree. If the changes were an elegant solution to the ambiguities
I never would have cared. In fact the whole reason I bothered to read the
patch in the first place was that I feel strongly that something like that
_was_ needed, but the solutions really seemed inferior to the original code
in terms of elegance of expression. (Well some of the original code was
pretty ugly too :-)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

 \ /
  Last update: 2005-03-22 12:41    [W:0.066 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site