lkml.org 
[lkml]   [1999]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] to include/linux/lp.h

> > This patch is mostly cosmetical.
> > Curently the 'interrupt enable' bit of parallel port has a symbol but
> > it is mixed with the comment of the missing 'direction' bit.
> >
> > Affected versions: 2.X, 1.3.18+
>
> This patch shouldn't be applied to 2.2 or onwards, since those symbols now
> live in parport.h.

Yes, it should not be, but MAY be.
The lp.h contains the incorrect line yet:

#define LP_PINTEN 0x10 /* high to read data in or-ed with data out */
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^???

(At least in 2.2.7)

And IMHO if there is one duplicated symbol there may be two also.

Gabor

----
Ooops! I've just understood, that this comment is totally bad even for
the 0x20 bit. If bit 0x20 is 0 the input and output will be AND-ed.
Otherwise the output drives does high-impedance state and does not
interfere with the input.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:52    [W:0.209 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site