Messages in this thread Patch in this message | | | Date | Wed, 22 Dec 1999 10:21:42 -0500 (EST) | From | (Steven S. Dick) | Subject | aha1542 patch |
| |
Alan, please apply this patch to 2.2.14. This is against 2.2.13 (I think) but applies cleanly to all 2.2.14pre1[0-2] at least. I'll try it against pre16 as soon as I have a chance to get a copy. This patch appears to be trivially correct, as it follows the pattern of other scsi_free calls.
Without this patch, aha1542 always causes a kernel panaic during scsi reset.
With this patch, scsi reset sometimes never occurs, and always recovers. (There is also a mailbox leak, but I don't know if it is related.)
If you don't apply this, please explain to me why.
--- linux/drivers/scsi/aha1542.c.orig Mon Aug 9 15:04:39 1999 +++ linux/drivers/scsi/aha1542.c Sun Sep 26 12:27:27 1999 @@ -482,7 +482,10 @@ } my_done = SCtmp->scsi_done; - if (SCtmp->host_scribble) scsi_free(SCtmp->host_scribble, 512); + if (SCtmp->host_scribble) { + scsi_free(SCtmp->host_scribble, 512); + SCtmp->host_scribble = 0; /* this fixes a fatal bug */ + } /* Fetch the sense data, and tuck it away, in the required slot. The Adaptec automatically fetches it, and there is no guarantee that - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |