Messages in this thread | | | Date | Fri, 29 Oct 1999 03:13:21 -0500 | From | Michael Elizabeth Chastain <> | Subject | Re: [PATCH] four warnings and a patch [AGAIN] |
| |
Hi Dennis,
I think duplicating that #ifdef is bad because now there are two places where a maintainer would have to change it.
I recommend just putting a comment in front of NS8390_trigger_send and letting this problem go.
I tried another fix, which is to make EI_SHIFT(x) always reference its argument (I was inspired by #define spin_lock in include/linux/spinlock.h). This fixes the 8390.c warning but breaks pcnet_cs.c.
This little warning isn't worth the trouble.
Michael
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |