Messages in this thread | | | Date | Fri, 7 Aug 1998 20:21:55 -0400 | From | "Theodore Y. Ts'o" <> | Subject | Re: [2.1.113] What is CHECK_TTY_COUNT warning me about? |
| |
Date: Fri, 07 Aug 1998 09:12:05 -0700 From: Bill Hawes <whawes@transmeta.com>
The particular bug complaining of tty->count not matching the fd's in use predates your console changes.
>From your patch above, I don't see how the tty->count would be directly affected -- the tty counts are decremented in release_dev independently of driver.close. So I think there must be some other factor operating here as well ...
For the serial driver, calling rs_hangup causes the serial count to be set to zero, since after a hangup the driver close functions aren't called when the release_dev is called in tty_io.c. So if the console devices aren't set to be marked as "hung up", rs_close() will be called when the console file descriptor is closed, and the serial count will go negative --- which at least one person has reported, so I think Miquel's patch is on track to fix at least some number of the reported problems.
Yes, I know the hangup architecture could use a severe rework. It's overly complicated and prone to race conditions. Another Linux 2.3 project.....
- Ted
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html
| |