lkml.org 
[lkml]   [1998]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [2.1.113] What is CHECK_TTY_COUNT warning me about?
    Miquel van Smoorenburg wrote:

    > As it happens I sent a patch to Linus for 2.1.115 (which hasn't been
    > applied ;( ) that fixes this. It has to to do with the DEV_SYSCONS code
    > so you can blaim the bug on me :)
    >



    > - if (tty->driver.hangup)
    > + if (cons_filp) {
    > + if (tty->driver.close)
    > + for (n = 0; n < closecount; n++)
    > + tty->driver.close(tty, cons_filp);
    > + } else if (tty->driver.hangup)
    > (tty->driver.hangup)(tty);
    > restore_flags(flags);
    > }
    >

    Hi Mike,

    The particular bug complaining of tty->count not matching the fd's in use
    predates your console changes.

    From your patch above, I don't see how the tty->count would be directly
    affected -- the tty counts are decremented in release_dev independently of
    driver.close. So I think there must be some other factor operating here as
    well ...

    Regards,
    Bill



    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.rutgers.edu
    Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html

    \
     
     \ /
      Last update: 2005-03-22 13:43    [W:0.020 / U:60.560 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site