Messages in this thread Patch in this message | | | From | Paul Rusty Russell <> | Subject | [PATCH] Re: [ipchains] logging tcp/udp port numbers | Date | Wed, 18 Nov 1998 11:53:22 +1130 |
| |
Linus, please apply.
The %h printk modifier is used in 5 source files, and doesn't work on ppc and sparc (vararg passing a short is broken on these platforms it seems).
This has bitten me twice now, both times on platforms I don't have access to. I'd prefer to see this nailed now.
Patch makes vsprintf ignore the `h' modifier.
--- linux/lib/vsprintf.c.~1~ Fri Nov 13 18:08:39 1998 +++ linux/lib/vsprintf.c Sat Nov 14 13:32:04 1998 @@ -289,12 +289,7 @@ } if (qualifier == 'l') num = va_arg(args, unsigned long); - else if (qualifier == 'h') { - if (flags & SIGN) - num = va_arg(args, short); - else - num = va_arg(args, unsigned short); - } else if (flags & SIGN) + else if (flags & SIGN) num = va_arg(args, int); else num = va_arg(args, unsigned int); -- .sig lost in the mail. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |