lkml.org 
[lkml]   [1998]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] bug in fs/isofs/inode.c (2.0.x & 2.1.x)
Hi Cyrill and linux-kernel-hackers,

just read about your ISO-HS-patch, and I agree.
For this special case when both signatures (HS and ISO) are found,
we should favor ISO, and recognize High Sierra only, when no ISO
signature is found.
Since ISO came later, the case of having a HS cd, which
by chance has a valid ISO signature, is too improbable to be
encountered. In this really happens, explicit mount options should
be used.

Regarding the patch:
The comment
/* Just skip any volume descriptors we don't recognize */
should be moved behind the ISO detection. Otherwise it is fine.
And please add a comment, why this change had been done.

I agree with your fix. It should be included in the kernels.

ciao,
Heiko



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:45    [W:0.043 / U:0.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site