lkml.org 
[lkml]   [1998]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Reducing the pressure
Date
: On 01-Oct-98 Larry McVoy wrote:
: > takepatch - apply a bitkeeper change set from a patch
: >
: > You use this to suck in a patch and apply it. It updates all the
: > files as well as the ChangeSet file which has an entry pointing
: > to all the files that you just changed. In deference to Linus'
: > work habits, it lets you edit the patch before applying it
: > (it lets you edit a copy of the patch, if you actually do change
: > anything in the pach, then the patch will go in as two deltas -
: > the base patch under the user id of the person that sent plus
: > another delta on top under the user id of whoever changed it).
: > [snip]
: >
: > Sound OK?
:
: you are working on the assumption that patches are discrete units

I'm not sure what you mean by that.

: what i'm proposing is a tool to allow for the inspection of a "patch" from a
: number of different angles.

As far as I am oncerned, all of these fairly useful ideas ought to be
options (or defaults) to takepatch.

: look at what files it touches. grep '^diff' patch. well now, it indeed touches
: the set of files the author said it should, but wait here! why is it touching
: /etc/passwd.

That's a cute one.

: ok so the patch looks ok! does it apply cleanly. well lets have a try (because
: it is the only way to find out). better keep a record of what it does.
: script foo
: patch -p1 <mumble
: ^D
: grep rej foo
:
: so 245 hunks failed eh!
: no so good
: mailx luser-author@nowheresville.com
: Subject: that piece of crap patch that you sent me!
: blah blah blah

takepatch fails the entire patch if it doesn't all apply properly. It
either all works or none of it works, no partial takes.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:44    [W:0.035 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site