lkml.org 
[lkml]   [1998]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Subject2.1.78 compile error
Date
From
Building coda as a module, I get, in addition to some warnings:

symlink.c:54: conflicting types for `coda_readlink'
symlink.c:27: previous declaration of `coda_readlink'
symlink.c: In function `coda_readlink':
symlink.c:55: structure has no member named `d_inode'

Given that the prototype is:
static int coda_readlink(struct dentry *dentry, char *buffer, int length);

but the function definition starts out as:

static int coda_readlink(struct inode *dentry, char *buffer, int length)
{
struct inode *inode = dentry->d_inode;

"struct inode *dentry"?!? Wasn't there some warning in the Intercal
manual about the badness of misspelling, e.g. "reinstate" F-O-R-G-E-T?

Apply this patch to fs/coda/symlink.c to make 2.1.78 compile with coda:

53c53
< static int coda_readlink(struct inode *dentry, char *buffer, int length)
---
> static int coda_readlink(struct dentry *dentry, char *buffer, int length)


Keith ("struct inode *dentry" indeed. Freudian slip?)


\
 
 \ /
  Last update: 2005-03-22 13:41    [W:0.034 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site