Messages in this thread | | | From | Liao Chang <> | Subject | [PATCH 0/9] Rework the DAIF mask, unmask and track API | Date | Tue, 9 Apr 2024 01:23:35 +0000 |
| |
This patch series reworks the DAIF mask, unmask, and track API for the upcoming FEAT_NMI extension added in Armv8.8.
As platform and virtualization[1] supports for FEAT_NMI is emerging, and Mark Brown's FEAT_NMI patch series[2] highlighted the need for clean up the existing hacking style approach about DAIF management code before adding NMI functionality, furthermore, we discover some subtle bugs during 'perf' and 'ipi_backtrace' transition from PSEUDO_NMI to FEAT_NMI, in summary, all of these emphasize the importance of rework.
This series of reworking patches follows the suggestion from Mark Rutland mentioned in Mark Brown's patchset. In summary, he think the better way for DAIF manangement look likes as following:
(a) Adding entry-specific helpers to manipulate abstract exception masks covering DAIF + PMR + ALLINT. Those need unmask-at-entry and mask-at-exit behaviour, and today only need to manage DAIF + PMR.
It should be possible to do this ahead of ALLINT / NMI support.
(b) Adding new "logical exception mask" helpers that treat DAIF + PMR + ALLINT as separate elements.
This patches cherry-pick a part of Mark Brown' FEAT_NMI series, in order to pass compilation and basic testing, includes perf and ipi_backtrace.
[1] https://lore.kernel.org/all/20240407081733.3231820-1-ruanjinjie@huawei.com/ [2] https://lore.kernel.org/linux-arm-kernel/Y4sH5qX5bK9xfEBp@lpieralisi/
Jinjie Ruan (1): arm64/cpufeature: Simplify detect PE support for FEAT_NMI
Liao Chang (5): arm64/cpufeature: Use alternatives to check enabled ARM64_HAS_NMI feature arm64: daifflags: Add logical exception masks covering DAIF + PMR + ALLINT arm64: Unify exception masking at entry and exit of exception arm64: Deprecate old local_daif_{mask,save,restore} irqchip/gic-v3: Improve the maintainability of NMI masking in GIC driver
Mark Brown (3): arm64/sysreg: Add definitions for immediate versions of MSR ALLINT arm64/cpufeature: Detect PE support for FEAT_NMI arm64/nmi: Add Kconfig for NMI
arch/arm64/Kconfig | 17 ++ arch/arm64/include/asm/cpufeature.h | 6 + arch/arm64/include/asm/daifflags.h | 296 ++++++++++++++++++++++----- arch/arm64/include/asm/nmi.h | 27 +++ arch/arm64/include/asm/sysreg.h | 2 + arch/arm64/include/uapi/asm/ptrace.h | 1 + arch/arm64/kernel/acpi.c | 10 +- arch/arm64/kernel/cpufeature.c | 58 +++++- arch/arm64/kernel/debug-monitors.c | 7 +- arch/arm64/kernel/entry-common.c | 96 +++++---- arch/arm64/kernel/entry.S | 2 - arch/arm64/kernel/hibernate.c | 6 +- arch/arm64/kernel/irq.c | 2 +- arch/arm64/kernel/machine_kexec.c | 2 +- arch/arm64/kernel/setup.c | 2 +- arch/arm64/kernel/smp.c | 6 +- arch/arm64/kernel/suspend.c | 6 +- arch/arm64/kvm/hyp/vgic-v3-sr.c | 6 +- arch/arm64/kvm/hyp/vhe/switch.c | 4 +- arch/arm64/mm/mmu.c | 6 +- arch/arm64/tools/cpucaps | 2 + drivers/irqchip/irq-gic-v3.c | 6 +- 22 files changed, 438 insertions(+), 132 deletions(-) create mode 100644 arch/arm64/include/asm/nmi.h
-- 2.34.1
| |