Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Ryusuke Konishi <> | Subject | [PATCH -mm] nilfs2: Remove calls to folio_set_error() and folio_clear_error() | Date | Tue, 30 Apr 2024 14:09:01 +0900 |
| |
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Nobody checks this flag on nilfs2 folios, stop setting and clearing it. That lets us simplify nilfs_end_folio_io() slightly.
Link: https://lkml.kernel.org/r/20240420025029.2166544-17-willy@infradead.org Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com> --- Andrew, please add this to the queue for the next merge window.
This is one of Matthew's PG_error removal series, and is one that is encouraged to be picked up by maintainers if possible. As expected for a cleanup patch, no issues have arisen.
Thanks, Ryusuke Konishi
fs/nilfs2/dir.c | 1 - fs/nilfs2/segment.c | 8 +------- 2 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/fs/nilfs2/dir.c b/fs/nilfs2/dir.c index aee40db7a036..a002a44ff161 100644 --- a/fs/nilfs2/dir.c +++ b/fs/nilfs2/dir.c @@ -174,7 +174,6 @@ static bool nilfs_check_folio(struct folio *folio, char *kaddr) dir->i_ino, (folio->index << PAGE_SHIFT) + offs, (unsigned long)le64_to_cpu(p->inode)); fail: - folio_set_error(folio); return false; } diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index aa5290cb7467..8654ab8ad534 100644 --- a/fs/nilfs2/segment.c +++ b/fs/nilfs2/segment.c @@ -1725,14 +1725,8 @@ static void nilfs_end_folio_io(struct folio *folio, int err) return; } - if (!err) { - if (!nilfs_folio_buffers_clean(folio)) - filemap_dirty_folio(folio->mapping, folio); - folio_clear_error(folio); - } else { + if (err || !nilfs_folio_buffers_clean(folio)) filemap_dirty_folio(folio->mapping, folio); - folio_set_error(folio); - } folio_end_writeback(folio); } -- 2.34.1
| ![\](/images/icornerr.gif) |