Messages in this thread | | | Date | Sat, 27 Apr 2024 22:36:12 -0700 | Subject | [RFC PATCH v2 0/3] Retirement latency perf stat support | From | Ian Rogers <> |
| |
Support 'R' as a retirement latency modifier on events. When present the evsel will fork perf record and perf report commands, parsing the perf report output as the count value. The intent is to do something similar to Weilin's series: https://lore.kernel.org/lkml/20240402214436.1409476-1-weilin.wang@intel.com/
While the 'R' and the retirement latency are Intel specific, in the future I can imagine more evsel like commands that require child processes. We can make the logic more generic at that point.
The code is untested on hardware that supports retirement latency, and with metrics with retirement latency in them. The record is also of sleep and various things need tweaking but I think v1 is good enough for people to give input.
The first patch refactors tool events. I came across various issues while looking into the issue and we can likely just pick it first. I kept it in the series for cleanliness sake.
The code has benefitted greatly from Weilin's work and Namhyung's great review input.
v2. Better refactor tool events to support interval mode and more. Switch "weight1" to "retire_lat" in perf report command. Ensure max precision 'P' is enabled on the perf record command. Kill the perf record at read but keep sleep 0.1. Fix issues around perf record of tool and retirement latency events.
Ian Rogers (3): perf evsel: Refactor tool events perf parse-events: Add a retirement latency modifier perf evsel: Add retirement latency event support
tools/perf/builtin-stat.c | 74 +++--- tools/perf/util/evsel.c | 409 ++++++++++++++++++++++++++++++++- tools/perf/util/evsel.h | 10 + tools/perf/util/parse-events.c | 2 + tools/perf/util/parse-events.h | 1 + tools/perf/util/parse-events.l | 3 +- 6 files changed, 453 insertions(+), 46 deletions(-)
-- 2.44.0.769.g3c40516874-goog
| |