Messages in this thread | | | Date | Tue, 23 Apr 2024 18:40:48 +0800 | From | Huang Rui <> | Subject | Re: [PATCH v7 1/6] cpufreq: acpi: move MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h |
| |
On Tue, Apr 23, 2024 at 04:40:54PM +0800, Yuan, Perry wrote: > There are some other drivers also need to use the > MSR_K7_HWCR_CPB_DIS_BIT for CPB control bit, so it makes sense to move > the definition to a common header file to allow other driver to use it. > > No intentional functional impact. > > Suggested-by: Gautham Ranjal Shenoy <gautham.shenoy@amd.com> > Signed-off-by: Perry Yuan <perry.yuan@amd.com> > Acked-by: Rafael J. Wysocki <rafael@kernel.org>
Acked-by: Huang Rui <ray.huang@amd.com>
> --- > arch/x86/include/asm/msr-index.h | 2 ++ > drivers/cpufreq/acpi-cpufreq.c | 2 -- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h > index e72c2b872957..8738a7b3917d 100644 > --- a/arch/x86/include/asm/msr-index.h > +++ b/arch/x86/include/asm/msr-index.h > @@ -782,6 +782,8 @@ > #define MSR_K7_HWCR_IRPERF_EN BIT_ULL(MSR_K7_HWCR_IRPERF_EN_BIT) > #define MSR_K7_FID_VID_CTL 0xc0010041 > #define MSR_K7_FID_VID_STATUS 0xc0010042 > +#define MSR_K7_HWCR_CPB_DIS_BIT 25 > +#define MSR_K7_HWCR_CPB_DIS BIT_ULL(MSR_K7_HWCR_CPB_DIS_BIT) > > /* K6 MSRs */ > #define MSR_K6_WHCR 0xc0000082 > diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c > index 37f1cdf46d29..2fc82831bddd 100644 > --- a/drivers/cpufreq/acpi-cpufreq.c > +++ b/drivers/cpufreq/acpi-cpufreq.c > @@ -50,8 +50,6 @@ enum { > #define AMD_MSR_RANGE (0x7) > #define HYGON_MSR_RANGE (0x7) > > -#define MSR_K7_HWCR_CPB_DIS (1ULL << 25) > - > struct acpi_cpufreq_data { > unsigned int resume; > unsigned int cpu_feature; > -- > 2.34.1 >
| |