Messages in this thread | | | Date | Mon, 22 Apr 2024 17:34:25 +0200 | Subject | Re: [PATCH v1 0/3] thermal/debugfs: Fix and clean up trip point statistics updates | From | Daniel Lezcano <> |
| |
On 22/04/2024 13:37, Lukasz Luba wrote: > Hi Rafael, > > On 4/17/24 14:07, Rafael J. Wysocki wrote: >> Hi Everyone, >> >> The first patch in this series addresses the problem of updating trip >> point statistics prematurely for trip points that have just been >> crossed on the way down (please see the patch changelog for details). >> >> The way it does that renders the following cleanup patch inapplicable: >> >> https://lore.kernel.org/linux-pm/2321994.ElGaqSPkdT@kreacher/ >> >> The remaining two patches in the series are cleanups on top of the >> first one. >> >> This series is based on an older patch series posted last week: >> >> https://lore.kernel.org/linux-pm/13515747.uLZWGnKmhe@kreacher/ >> >> but it can be trivially rebased on top of the current linux-next. >> >> Thanks! >> >> >> > > I've checked this patch patch set on top of your bleeding-edge > which has thermal re-work as well. The patch set looks good > and works properly. > > Although, I have found some issue in this debug info files and > I'm not sure if this is expected or not. If not I can address this > and send some small fix for it. > > When I read the cooling device residency statistics, I don't > get updates for the first time the state is used. It can only > be counted when that state was known and finished it's usage. > > IMO it is not the right behavior, isn't it?
Do you mean the right behavior is a regression or we should expect at least the residency to be showed even if the mitigation state is not closed ?
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |