Messages in this thread | | | Date | Mon, 22 Apr 2024 05:37:10 -0700 | Subject | Re: [PATCH 2/4] hwmon: (max6639) : Utilise pwm subsystem | From | Guenter Roeck <> |
| |
On 4/22/24 03:39, Naresh Solanki wrote: > Hi Guenter, > > On Wed, 17 Apr 2024 at 02:52, Guenter Roeck <linux@roeck-us.net> wrote: >> >> On Tue, Apr 16, 2024 at 10:47:15PM +0530, Naresh Solanki wrote: >>> Utilise pwm subsystem for fan pwm handling >>> >>> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> >> >> That adds a lot of complexity to the driver. I am missing the benefits. >> You are supposed to explain why you are making changes, not just that >> you are making them. >> >> Why are you making those changes ? > Sure. > This is to align with fan-common.yml wherein chip pwm is exposed. > I'll update commit message >
Adding lots of complexity to a driver just to have it match a yaml file ? I'll want to see a use case. Explain why you need the pwm exposed. "because the yaml file demands it" is not a use case.
Guenter
| |