Messages in this thread | | | From | Naresh Solanki <> | Date | Mon, 22 Apr 2024 16:09:14 +0530 | Subject | Re: [PATCH 2/4] hwmon: (max6639) : Utilise pwm subsystem |
| |
Hi Guenter,
On Wed, 17 Apr 2024 at 02:52, Guenter Roeck <linux@roeck-us.net> wrote: > > On Tue, Apr 16, 2024 at 10:47:15PM +0530, Naresh Solanki wrote: > > Utilise pwm subsystem for fan pwm handling > > > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> > > That adds a lot of complexity to the driver. I am missing the benefits. > You are supposed to explain why you are making changes, not just that > you are making them. > > Why are you making those changes ? Sure. This is to align with fan-common.yml wherein chip pwm is exposed. I'll update commit message
Regards, Naresh > > Guenter
| |