Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 17 Apr 2024 16:38:14 +0200 | Subject | Re: [PATCH] reset: reset-rzg2l-usbphy-ctrl: Ensure reset line is asserted in error path |
| |
Hi Prabhakar,
On Thu, Mar 21, 2024 at 12:43 PM Prabhakar <prabhakar.csengg@gmail.com> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > In the event of failure during devm_reset_controller_register(), ensure > that the reset line is asserted back. > > Fixes: bee08559701fb ("reset: renesas: Add RZ/G2L usbphy control driver") > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Thanks for your patch!
> --- a/drivers/reset/reset-rzg2l-usbphy-ctrl.c > +++ b/drivers/reset/reset-rzg2l-usbphy-ctrl.c > @@ -132,8 +132,10 @@ static int rzg2l_usbphy_ctrl_probe(struct platform_device *pdev) > priv->rcdev.dev = dev; > > error = devm_reset_controller_register(dev, &priv->rcdev); > - if (error) > + if (error) { > + reset_control_assert(priv->rstc); > return error; > + } > > spin_lock_init(&priv->lock); > dev_set_drvdata(dev, priv);
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Alternatively, you could register a cleanup handler with devm_add_action_or_reset(), like many drivers already do. Or better, turn devm_aspeed_peci_reset_control_deassert() into a generic helper, and convert all drivers[1] to use that.
That would just leave us with undoing pm_runtime_enable(), which can be automated using devm_pm_runtime_enable() instead.
[1] git grep -w devm.*reset_control_assert
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |