lkml.org 
[lkml]   [2024]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rust: update `dbg!()` to format column number
On Sun, 14 Apr 2024 18:49:28 +0530
<dev@raxyte.com> wrote:

> In Rust 1.76.0, the `dbg!()` macro was updated to also format the column
> number. The reason cited was usage of a few characters worth of
> horizontal space while allowing direct jumps to the source location. [1]
>
> Link: https://github.com/rust-lang/rust/pull/114962 [1]
> Link: https://github.com/Rust-for-Linux/linux/issues/1065
>
> Signed-off-by: Raghav Narang <dev@raxyte.com>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
> Branch rust-next
>
> rust/kernel/std_vendor.rs | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/rust/kernel/std_vendor.rs b/rust/kernel/std_vendor.rs
> index 388d6a514..39679a960 100644
> --- a/rust/kernel/std_vendor.rs
> +++ b/rust/kernel/std_vendor.rs
> @@ -146,15 +146,16 @@ macro_rules! dbg {
> // `$val` expression could be a block (`{ .. }`), in which case the `pr_info!`
> // will be malformed.
> () => {
> - $crate::pr_info!("[{}:{}]\n", ::core::file!(), ::core::line!())
> + $crate::pr_info!("[{}:{}:{}]\n", ::core::file!(), ::core::line!(), ::core::column!())
> };
> ($val:expr $(,)?) => {
> // Use of `match` here is intentional because it affects the lifetimes
> // of temporaries - https://stackoverflow.com/a/48732525/1063961
> match $val {
> tmp => {
> - $crate::pr_info!("[{}:{}] {} = {:#?}\n",
> - ::core::file!(), ::core::line!(), ::core::stringify!($val), &tmp);
> + $crate::pr_info!("[{}:{}:{}] {} = {:#?}\n",
> + ::core::file!(), ::core::line!(), ::core::column!(),
> + ::core::stringify!($val), &tmp);
> tmp
> }
> }
>
> base-commit: 8db31d3f3bd5dbc8cf3a22bba04b4b4add7f984e


\
 
 \ /
  Last update: 2024-04-17 15:52    [W:0.026 / U:0.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site