Messages in this thread | | | From | Anna-Maria Behnsen <> | Subject | Re: [patch V2 07/50] posix-cpu-timers: Split up posix_cpu_timer_get() | Date | Wed, 17 Apr 2024 11:21:52 +0200 |
| |
Oleg Nesterov <oleg@redhat.com> writes:
> On 04/11, Thomas Gleixner wrote: >> >> In preparation for addressing issues in the timer_get() and timer_set() >> functions of posix CPU timers. > > Cough... I must have missed something, but posix_cpu_timer_get() > doesn't look right with or without this trivial patch. > > It doesn't initialize itp->it_value if cpu_timer_getexpires() == 0, > this means that sys_timer_gettime() will copy the uninitialized > cur_setting->it_value on the stack to userspace?
The initialization of itp is already done by the callsites. do_timer_settime() in posix-timers.c as well as do_cpu_nanosleep() in posix-cpu-timers.c execute a memset before calling posix_cpu_timer_get(). So this should be fine - or did I miss something here?
Thanks,
Anna-Maria
| |