Messages in this thread Patch in this message | | | From | Philippe Mathieu-Daudé <> | Subject | [PATCH] MIPS: SGI-IP30: Use bitmap API when iterating over bitmap | Date | Wed, 17 Apr 2024 09:18:29 +0200 |
| |
Do not open-code bitmap_set(). Besides, <linux/bitmap.h> API allows architecture specific optimizations, so prefer it.
Use the HEART_NUM_IRQS definition to express the end of the HEART bitmap.
Inspired-by: Yury Norov <yury.norov@gmail.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- arch/mips/sgi-ip30/ip30-irq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/mips/sgi-ip30/ip30-irq.c b/arch/mips/sgi-ip30/ip30-irq.c index 423c32cb66ed..bdafff076191 100644 --- a/arch/mips/sgi-ip30/ip30-irq.c +++ b/arch/mips/sgi-ip30/ip30-irq.c @@ -264,7 +264,6 @@ void __init arch_init_irq(void) struct irq_domain *domain; struct fwnode_handle *fn; unsigned long *mask; - int i; mips_cpu_irq_init(); @@ -300,8 +299,7 @@ void __init arch_init_irq(void) set_bit(HEART_L3_INT_TIMER, heart_irq_map); /* Reserve the error interrupts (#51 to #63). */ - for (i = HEART_L4_INT_XWID_ERR_9; i <= HEART_L4_INT_HEART_EXCP; i++) - set_bit(i, heart_irq_map); + bitmap_set(heart_irq_map, HEART_L4_INT_XWID_ERR_9, HEART_NUM_IRQS); fn = irq_domain_alloc_named_fwnode("HEART"); WARN_ON(fn == NULL); -- 2.41.0
| |