lkml.org 
[lkml]   [2024]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/2] rtc: rx8111: demote warnings to debug level
Date
From: Alexandre Belloni <alexandre.belloni@bootlin.com>

The proper way for userspace to react on a read time error is to have a
look at the voltage low information. There is no point in cluttering dmesg
as it is often not even visible to the end user.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
drivers/rtc/rtc-rx8111.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/rtc/rtc-rx8111.c b/drivers/rtc/rtc-rx8111.c
index 62d2352de102..4a35bd921b33 100644
--- a/drivers/rtc/rtc-rx8111.c
+++ b/drivers/rtc/rtc-rx8111.c
@@ -170,14 +170,14 @@ static int rx8111_read_time(struct device *dev, struct rtc_time *tm)
}

if (FIELD_GET(RX8111_FLAG_XST_BIT, regval)) {
- dev_warn(data->dev,
- "Crystal oscillation stopped, time is not reliable\n");
+ dev_dbg(data->dev,
+ "Crystal oscillation stopped, time is not reliable\n");
return -EINVAL;
}

if (FIELD_GET(RX8111_FLAG_VLF_BIT, regval)) {
- dev_warn(data->dev,
- "Low voltage detected, time is not reliable\n");
+ dev_dbg(data->dev,
+ "Low voltage detected, time is not reliable\n");
return -EINVAL;
}

@@ -188,7 +188,7 @@ static int rx8111_read_time(struct device *dev, struct rtc_time *tm)
}

if (regval) {
- dev_warn(data->dev, "Clock stopped, time is not reliable\n");
+ dev_dbg(data->dev, "Clock stopped, time is not reliable\n");
return -EINVAL;
}

--
2.44.0

\
 
 \ /
  Last update: 2024-04-17 21:20    [W:0.030 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site