lkml.org 
[lkml]   [2024]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v2 0/2] crypto: ecdh & ecc: Fix private key byte ordering issues
Date
The 1st patch fixes a byte ordering issue where ctx->private_key is
currently passed to ecc_is_key_valid but the key is in reverse byte order.
To solve this issue it introduces the variable 'priv' that is already used
throughout the ecc and ecdh code bases for a private key in proper byte
order and calls the function with 'priv'.

The 2nd patch gets rid of the 'priv' variable wherever it is used to hold
a private key (byte-swapped initialized from ctx->private_key) in proper
byte order and uses ctx->private_key directly that is now initialized in
proper byte order.

Regards,
Stefan

v2:
- Added missing zeroizing of priv variable (1/2)
- Improved patch description (2/2)


Stefan Berger (2):
crypto: ecdh - Pass private key in proper byte order to check valid
key
crypto: ecdh & ecc - Initialize ctx->private_key in proper byte order

crypto/ecc.c | 29 ++++++++++-------------------
crypto/ecdh.c | 9 ++++++---
include/crypto/internal/ecc.h | 3 ++-
3 files changed, 18 insertions(+), 23 deletions(-)

--
2.43.0


\
 
 \ /
  Last update: 2024-04-17 18:22    [W:0.306 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site