lkml.org 
[lkml]   [2024]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/3] hwmon: (max31790): Support config PWM output becomes TACH
From
Le 14/04/2024 à 06:22, Chanh Nguyen a écrit :
> PWMOUT pins on MAX31790 can be configured as a tachometer input pin by
> setting bit[0] in the Configuration Register. When the bit[0] of a channel
> is set, the PWMOUT pin becomes the tach input pin for the channel plus six.
>
> This commit allows the kernel to set those pins when necessary if the
> maxim,pwmout-pin-as-tach-input DT property exists.
>
> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> ---
> Changes in v2:
> - Update the vendor property name to "maxim,pwmout-pin-as-tach-input" [Rob]

..

> @@ -528,6 +532,33 @@ static int max31790_probe(struct i2c_client *client)
> if (err)
> return err;
>
> + if (device_property_present(dev, "maxim,pwmout-pin-as-tach-input")) {
> + err = device_property_read_u8_array(dev, "maxim,pwmout-pin-as-tach-input",
> + pwmout_to_tach, NR_CHANNEL);
> + if (err) {
> + /* The maxim,pwmout-pin-as-tach-input is an array of six values */
> + dev_warn(dev, "The maxim,pwmout-pin-as-tach-input property exist but malform");

Nit: exists
Nit: malformed or "is malformed"

CJ

\
 
 \ /
  Last update: 2024-04-14 10:03    [W:0.088 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site